As far as camo goes, I agree, match the terrain. As far as what kind of clothes to buy...I say, if someone has the money, who really cares what they buy. My base layers are camo because it's what I wanted. Did I pay a little more for them because of it? Yes, but I can afford it and in a free society we can do whatever we want.
Do brands like Scent Blocker really help much? Maybe, but I really don't know. But I can tell you that their clothes are high quality and mine have been put to the test. Same with my Under Armour..they are tough. Heck, I paid $300 for my Drake Waterfowl Systems parka and that thing has kept me warm and completely dry for several years and I beat the crap out of it. So I say, if you've got the cash and you want it...get it!